-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect node sass and react version #13968
Detect node sass and react version #13968
Conversation
mmmmergeee
Failing test suitestest/integration/app-functional/test/index.test.js
Expand output● Document and App › should not have any missing key warnings
● Test suite failed to run
test/integration/app-document/test/index.test.js
Expand output● Document and App › should not have any missing key warnings
● Document and App › Rendering via HTTP › _document › It has a custom html class
● Document and App › Rendering via HTTP › _document › It has a custom body class
● Document and App › Rendering via HTTP › _document › It injects custom head tags
● Document and App › Rendering via HTTP › _document › It passes props from Document.getInitialProps to Document
● Document and App › Rendering via HTTP › _document › It adds nonces to all scripts and preload links
● Document and App › Rendering via HTTP › _document › It adds crossOrigin to all scripts and preload links
● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhancer correctly
● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceComponent correctly
● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceApp correctly
● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceApp and enhanceComponent correctly
● Document and App › Rendering via HTTP › _document › It adds a timestamp to link tags with preload attribute to invalidate the cache (DEV only)
● Document and App › Rendering via HTTP › _app › It shows a custom tag
● Document and App › Rendering via HTTP › _app › It should share module state with pages
● Document and App › Rendering via HTTP › _app › It should show valid error when thrown in _app getInitialProps
● Document and App › Client side › should detect the changes to pages/_app.js and display it
● Document and App › Client side › should detect the changes to pages/_document.js and display it
● Document and App › Client side › should keep state between page navigations
● Document and App › Client side › It should share module state with pages
● Document and App › With CSP enabled › should load inline script by hash
● Document and App › With CSP enabled › should load inline script by nonce
● Test suite failed to run
test/integration/amphtml-fragment-style/test/index.test.js
Expand output● AMP Fragment Styles › adds styles from fragment in AMP mode correctly
● Test suite failed to run
test/integration/amphtml-custom-optimizer/test/index.test.js
Expand output● AMP Custom Optimizer › should build and start for static page
● AMP Custom Optimizer › should build and start for dynamic page
test/integration/amphtml-ssg/test/index.test.js
Expand output● AMP SSG Support › serverless mode › should load an amp first page correctly
● AMP SSG Support › serverless mode › should load a hybrid amp page without query correctly
● AMP SSG Support › serverless mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › serverless mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › serverless mode › should load a hybrid amp page with query correctly
● AMP SSG Support › serverless mode › should output prerendered files correctly during build
● AMP SSG Support › server mode › should load an amp first page correctly
● AMP SSG Support › server mode › should load a hybrid amp page without query correctly
● AMP SSG Support › server mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › server mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › server mode › should load a hybrid amp page with query correctly
● AMP SSG Support › server mode › should output prerendered files correctly during build
● AMP SSG Support › dev mode › should load an amp first page correctly
● AMP SSG Support › dev mode › should load a hybrid amp page without query correctly
● AMP SSG Support › dev mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › dev mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › dev mode › should load a hybrid amp page with query correctly
● AMP SSG Support › export mode › should have copied SSG files correctly
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
test/integration/catches-missing-getStaticProps/test/index.test.js
Expand output● Catches Missing getStaticProps › should catch it in dev mode
● Catches Missing getStaticProps › should catch it in server build mode
● Catches Missing getStaticProps › should catch it in serverless mode
|
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
buildDuration | 11.1s | 11.1s | |
nodeModulesSize | 64.9 MB | 64.9 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.998 | 1.888 | -0.11 |
/ avg req/sec | 1251.23 | 1324.5 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.357 | 1.211 | -0.15 |
/error-in-render avg req/sec | 1842.79 | 2065.15 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.js gzip | 6.49 kB | 6.49 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..ec24.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.9 kB | 56.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.58 kB | 5.58 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.22 kB | 8.22 kB | ✓ |
Client Pages Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.33 kB | 5.33 kB | ✓ |
Client Build Manifests
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_buildManifest.js gzip | 171 B | 171 B | ✓ |
_buildManife..dule.js gzip | 180 B | 180 B | ✓ |
Overall change | 351 B | 351 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
index.html gzip | 901 B | 901 B | ✓ |
link.html gzip | 906 B | 906 B | ✓ |
withRouter.html gzip | 894 B | 894 B | ✓ |
Overall change | 2.7 kB | 2.7 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
buildDuration | 13.1s | 11.7s | -1.3s |
nodeModulesSize | 64.9 MB | 64.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.js gzip | 6.49 kB | 6.49 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..ec24.js gzip | 10.5 kB | 10.5 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 56.9 kB | 56.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.58 kB | 5.58 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.92 kB | 6.92 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.22 kB | 8.22 kB | ✓ |
Client Pages Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.33 kB | 5.33 kB | ✓ |
Client Build Manifests
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_buildManifest.js gzip | 171 B | 171 B | ✓ |
_buildManife..dule.js gzip | 180 B | 180 B | ✓ |
Overall change | 351 B | 351 B | ✓ |
Serverless bundles
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_error.js | 874 kB | 874 kB | ✓ |
404.html | 4.13 kB | 4.13 kB | ✓ |
hooks.html | 3.71 kB | 3.71 kB | ✓ |
index.js | 875 kB | 875 kB | ✓ |
link.js | 913 kB | 913 kB | ✓ |
routerDirect.js | 905 kB | 905 kB | ✓ |
withRouter.js | 905 kB | 905 kB | ✓ |
Overall change | 4.48 MB | 4.48 MB | ✓ |
@Timer I believe this is ready for review. If you have the time to give me some directions on how I could check with different dependencies @ integration tests I would love to create the required tests! |
Failing test suitestest/integration/api-catch-all/test/index.test.js
Expand output● API routes › dev support › should return data when catch-all
● API routes › dev support › should 404 when catch-all with index and trailing slash
● API routes › dev support › should return data when catch-all with index and no trailing slash
● API routes › Server support › should return data when catch-all
● API routes › Server support › should 404 when catch-all with index and trailing slash
● API routes › Server support › should return data when catch-all with index and no trailing slash
● API routes › Serverless support › should return data when catch-all
● API routes › Serverless support › should 404 when catch-all with index and trailing slash
● API routes › Serverless support › should return data when catch-all with index and no trailing slash
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
test/integration/app-document-import-order/test/index.test.js
Expand output● Root components import order › root components should be imported in this order _document > _app > page in order to respect side effects
● Root components import order › _app chunks should be attached to de dom before page chunks
● Root components import order › on dev server › root components should be imported in this order _document > _app > page in order to respect side effects
● Root components import order › on dev server › _app chunks should be attached to de dom before page chunks
● Test suite failed to run
● Test suite failed to run
test/integration/amphtml-fragment-style/test/index.test.js
Expand output● AMP Fragment Styles › adds styles from fragment in AMP mode correctly
● Test suite failed to run
test/integration/amphtml-ssg/test/index.test.js
Expand output● AMP SSG Support › serverless mode › should load an amp first page correctly
● AMP SSG Support › serverless mode › should load a hybrid amp page without query correctly
● AMP SSG Support › serverless mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › serverless mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › serverless mode › should load a hybrid amp page with query correctly
● AMP SSG Support › serverless mode › should output prerendered files correctly during build
● AMP SSG Support › server mode › should load an amp first page correctly
● AMP SSG Support › server mode › should load a hybrid amp page without query correctly
● AMP SSG Support › server mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › server mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › server mode › should load a hybrid amp page with query correctly
● AMP SSG Support › server mode › should output prerendered files correctly during build
● AMP SSG Support › dev mode › should load an amp first page correctly
● AMP SSG Support › dev mode › should load a hybrid amp page without query correctly
● AMP SSG Support › dev mode › should load dynamic hybrid SSG/AMP page
● AMP SSG Support › dev mode › should load dynamic hybrid SSG/AMP page with query
● AMP SSG Support › dev mode › should load a hybrid amp page with query correctly
● AMP SSG Support › export mode › should have copied SSG files correctly
● Test suite failed to run
● Test suite failed to run
● Test suite failed to run
test/integration/build-warnings/test/index.test.js
Expand output● Build warnings › should shown warning about minification for minimize
● Build warnings › should shown warning about minification for minimizer
test/integration/build-output/test/index.test.js
Expand output● Build Output › Basic Application Output › should not include internal pages
● Build Output › Basic Application Output › should not deviate from snapshot
● Build Output › Custom App Output › should not include custom error
● Build Output › With AMP Output › should not include custom error
● Build Output › Custom Error Output › should not include custom app
● Build Output › Custom Static Error Output › should not specify /404 as lambda when static
|
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
buildDuration | 11.1s | 12.3s | |
nodeModulesSize | 64.9 MB | 64.9 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.915 | 2.108 | |
/ avg req/sec | 1305.54 | 1186.12 | -119.42 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.226 | 1.414 | |
/error-in-render avg req/sec | 2039.93 | 1767.87 | -272.06 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.js gzip | 6.49 kB | 6.49 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..f367.js gzip | 10.9 kB | 10.9 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.58 kB | 5.58 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 7.27 kB | 7.27 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.7 kB | 52.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
Overall change | 8.22 kB | 8.22 kB | ✓ |
Client Pages Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
index.module.js gzip | 223 B | 223 B | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
_app.module.js gzip | 604 B | 604 B | ✓ |
Overall change | 5.33 kB | 5.33 kB | ✓ |
Client Build Manifests
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_buildManifest.js gzip | 270 B | 270 B | ✓ |
_buildManife..dule.js gzip | 275 B | 275 B | ✓ |
Overall change | 545 B | 545 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
index.html gzip | 955 B | 955 B | ✓ |
link.html gzip | 961 B | 961 B | ✓ |
withRouter.html gzip | 948 B | 948 B | ✓ |
Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
buildDuration | 12.5s | 13.1s | |
nodeModulesSize | 64.9 MB | 64.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.js gzip | 6.49 kB | 6.49 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..f367.js gzip | 10.9 kB | 10.9 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57.2 kB | 57.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.58 kB | 5.58 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 7.27 kB | 7.27 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.7 kB | 52.7 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.05 kB | 2.05 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.25 kB | 3.25 kB | ✓ |
Overall change | 8.22 kB | 8.22 kB | ✓ |
Client Pages Modern
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
index.module.js gzip | 223 B | 223 B | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
_error.module.js gzip | 2.04 kB | 2.04 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
_app.module.js gzip | 604 B | 604 B | ✓ |
Overall change | 5.33 kB | 5.33 kB | ✓ |
Client Build Manifests
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_buildManifest.js gzip | 270 B | 270 B | ✓ |
_buildManife..dule.js gzip | 275 B | 275 B | ✓ |
Overall change | 545 B | 545 B | ✓ |
Serverless bundles
vercel/next.js canary | TodorTotev/next.js detect-node-sass-and-react-version | Change | |
---|---|---|---|
_error.js | 875 kB | 875 kB | ✓ |
404.html | 4.17 kB | 4.17 kB | ✓ |
hooks.html | 3.79 kB | 3.79 kB | ✓ |
index.js | 875 kB | 875 kB | ✓ |
link.js | 915 kB | 915 kB | ✓ |
routerDirect.js | 907 kB | 907 kB | ✓ |
withRouter.js | 907 kB | 907 kB | ✓ |
Overall change | 4.49 MB | 4.49 MB | ✓ |
@@ -263,6 +263,26 @@ export default async function getBaseWebpackConfig( | |||
resolvedBaseUrl = path.resolve(dir, jsConfig.compilerOptions.baseUrl) | |||
} | |||
|
|||
if (isServer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check should exist in packages/next/cli/next-dev.ts
@@ -263,6 +263,26 @@ export default async function getBaseWebpackConfig( | |||
resolvedBaseUrl = path.resolve(dir, jsConfig.compilerOptions.baseUrl) | |||
} | |||
|
|||
if (isServer) { | |||
const packageJsonPath = path.resolve(dir, './package.json') | |||
const packageJsonFile = parseJsonFile(packageJsonPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the version of React in their package.json might not be comprehensive enough. They could have ^16.8.6
but if they did their initial installation recently then they might actually have 16.13.1
installed as their React version (due to the version using the ^
which will bump them to the next minor version released).
I think checking their installed dependencies might give you a bit more coverage:
const packagePath = require.resolve('react/package.json')
const { version } = require(packagePath)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted! Will change it!
Closes 13961
Closes 13953
@Timer @timneutkens Will cc you when done.